[Webkit-unassigned] [Bug 13699] Consolidate notImplemented() macro definitions into header

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13699





------- Comment #2 from sam at webkit.org  2007-05-12 19:33 PDT -------
(From update of attachment 14521)
This seems like a good idea.  A couple points you may want to address:

In NotImplemented.h

- for the non-debug version of notImplemented() you may want to use (void(0))
as we do for ASSERT instead of {}.

- the Qt and else versions should use WTF_PRETTY_FUNCTION instead of
__FUNCTION__.

In WebKit/COM/ChromeClientWin.cpp

- you don't #include NotImplemented.h, you have just redefined the empty macro.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.