[Webkit-unassigned] [Bug 13572] Arabic characters are not correctly joined when using Arial

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13572


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14476|0                           |1
        is obsolete|                            |
  Attachment #14488|                            |review?
               Flag|                            |




------- Comment #16 from mitz at webkit.org  2007-05-11 06:10 PDT -------
Created an attachment (id=14488)
 --> (http://bugs.webkit.org/attachment.cgi?id=14488&action=view)
Add a private stripped-down version of u_shapeArabic that handles the
non-Arabic languages

(In reply to comment #14)
> (From update of attachment 14476 [edit])
> I'm surprised by the function name. In what way is this Macintosh-specific?

I removed "Mac" from the function and file names, but I left them in the
platform/mac
subdirectory, since this code is not cross-platform (and in that sense it is
Macintosh-specific). I really hope this hack can be removed in the future.

> I don't think we need to use U_CAPI and U_EXPORT2 in an internal WebCore
> header.

Fixed.

> Typically we capitalize filenames, so I would call this ShapeArabicMac.h/cpp.

Fixed.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.