[Webkit-unassigned] [Bug 13572] Arabic characters are not correctly joined when using Arial

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13572


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14476|review?                     |review+
               Flag|                            |




------- Comment #14 from darin at apple.com  2007-05-10 13:40 PDT -------
(From update of attachment 14476)
I'm surprised by the function name. In what way is this Macintosh-specific?

It's hard to review the differences in this between the ICU version and the new
version because the diff just shows the new code.

I don't think we need to use U_CAPI and U_EXPORT2 in an internal WebCore
header.

Typically we capitalize filenames, so I would call this ShapeArabicMac.h/cpp.

I'm comfortable with this patch despite those concerns. So I'm going to mark
this review+ -- feel free to clear the review flag if you want to do a new
version.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.