[Webkit-unassigned] [Bug 13090] curl (linux/gdk) networking improvements

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13090





------- Comment #4 from kimmok at iki.fi  2007-05-07 15:16 PDT -------
Created an attachment (id=14401)
 --> (http://bugs.webkit.org/attachment.cgi?id=14401&action=view)
Curl re-entrancy problem: tries to reuse semi-active handle

Segfault when libcurl tries to share handle which is not finished yet.

man curl_easy_handle:
"If the curl handles are used simultaneously, you MUST use  the  locking 
methods  in  the  share  handle."

When libcurl-gnutls (ubuntu package) is concerned, "simultaneously" means not
calling add when you have received callback from that originates from
curl_multi_perform.


Temp fix:
--
Index: platform/network/gdk/ResourceHandleManager.cpp
===================================================================
--- platform/network/gdk/ResourceHandleManager.cpp      (revision 21288)
+++ platform/network/gdk/ResourceHandleManager.cpp      (working copy)
@@ -188,7 +188,6 @@ void ResourceHandleManager::add(Resource
     curl_easy_setopt(d->m_handle, CURLOPT_FOLLOWLOCATION, 1);
     curl_easy_setopt(d->m_handle, CURLOPT_MAXREDIRS, 10);
     curl_easy_setopt(d->m_handle, CURLOPT_HTTPAUTH, CURLAUTH_ANY);
-    curl_easy_setopt(d->m_handle, CURLOPT_SHARE, m_curlShareHandle);
     // enable gzip and deflate through Accept-Encoding:
     curl_easy_setopt(d->m_handle, CURLOPT_ENCODING, "");


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.