[Webkit-unassigned] [Bug 13601] New: plugInViewWithArguments: called with truncated argument dict when baseURL is nil

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13601

           Summary: plugInViewWithArguments: called with truncated argument
                    dict when baseURL is nil
           Product: WebKit
           Version: 522+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: speth at end.com


when WebKit plugins are created by WebFrameBridge, if their base URL is nil,
the plugInViewWithArguments: method is called with an argument dictionary that
is missing some values.  most noticeably, WebPlugInContainingElementKey is
missing.

see the comment at WebFrameBridge.mm:460:
    // URL might be nil, so add it last
however, it's not last anymore, so when it is nil, all the values after it in
the call to dictionaryWithObjectsAndKeys: are ignored.  so, we need to pay
attention to the comment and put WebPlugInBaseURLKey last, or create the
dictionary some other way.

I'll make a test case and patch for it, unless someone beats me to it, but i
wanted get this in bugzilla before I forget again.

also, this problem exists both places that dictionary could be created:
   
viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:
   
pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:
so we should fix them both, or have them call a common method to create the
dictionary.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.