[Webkit-unassigned] [Bug 13592] parseMappedAttribute inconsistency

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13592


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14350|review?                     |review-
               Flag|                            |




------- Comment #2 from oliver at apple.com  2007-05-05 03:58 PDT -------
(From update of attachment 14350)
*SVGAnimateMotionElement::parseMappedAttribute

I'd lift add const String& value = attr-value() after the first name check.  It
seem icky to query multiple times.

*SVGAnimateTransformElement::parseMappedAttribute
I don't think this gains anything.

*SVGAnimationElement::parseMappedAttribute
in those cases where you access attr->value() multiple times i think you should
just declare a var.  eg. the attributeTypeAttr case.

*SVGCircleElement::parseMappedAttribute
*SVGClipPathElement::parseMappedAttribute
*SVGCursorElement::parseMappedAttribute
*SVGEllipseElement::parseMappedAttribute
I'd consider a local const& to hold the name, but otherwise looks good

*SVGExternalResourcesRequired::parseMappedAttribute
looks good

*SVGGradientElement::parseMappedAttribute
local for the attribute name, and maybe use locals in those branches that query
the value multiple times.

*SVGImageElement::parseMappedAttribute
*SVGLineElement::parseMappedAttribute
*SVGLinearGradientElement::parseMappedAttribute
*SVGMarkerElement::parseMappedAttribute
*SVGMaskElement::parseMappedAttribute
*SVGPathElement::parseMappedAttribute
local for the name again

*SVGPatternElement::parseMappedAttribute
local for name, local for value on those branches that access the value
multiple times

*SVGRadialGradientElement::parseMappedAttribute
*SVGRectElement::parseMappedAttribute
local for the name

*SVGSVGElement::parseMappedAttribute
local for name, local for value those places it's used multiple times

*SVGScriptElement::parseMappedAttribute
ooh, good *and* fixed indenting

*SVGStopElement::parseMappedAttribute
*SVGTests::parseMappedAttribute
*SVGTextContentElement::parseMappedAttribute
*SVGTextPositioningElement::parseMappedAttribute
*SVGUseElement::parseMappedAttribute
local for name if it's used multiple imes

*SVGViewElement::parseMappedAttribute
good

*SVGZoomAndPan::parseMappedAttribute
local for value when it's used multiple times


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.