[Webkit-unassigned] [Bug 13592] New: parseMappedAttribute inconsistency

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13592

           Summary: parseMappedAttribute inconsistency
           Product: WebKit
           Version: 522+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rwlbuis at gmail.com


parseMappedAttribute a lot of the time sets a local var to get the attribute
value. In a lot of cases, as shown by the coverage results, this value is not
used at all. This is very clear here:

http://www.openembedded.org/~zecke/coverage/webkit/mac/__WebCore__ksvg2__svg__SVGZoomAndPan.cpp.html

Also half the time here the value is not used:

http://www.openembedded.org/~zecke/coverage/webkit/mac/__WebCore__ksvg2__svg__SVGLinearGradientElement.cpp.html

Even though a compiler may be able to optimize the local var away, I think it
is better to make it clear and be consistent with html code here too. Patch
coming up.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.