[Webkit-unassigned] [Bug 13499] [qmake] Make it possible to use qmake for other ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 03:10:57 PDT 2007


bdash at webkit.org changed:

           What    |Removed                     |Added
  Attachment #14293|review?                     |review-
               Flag|                            |

------- Comment #15 from bdash at webkit.org  2007-05-02 03:10 PDT -------
(From update of attachment 14293)
+    if ((isGdk()) and ($path =~ /WebCore/)) {

I dont think you need so many parenthesis here.

+sub isGdk()
+    return defined($ENV{'BUILD_GDK'})

It would be great if this could be controlled by a build-webkit command-line
argument.  It's more natural to do 'build-webkit --gdk' than 'BUILD_GDK=1
build-webkit' IMO.

+sub buildQMakeGdkProject($$)

Inside this function there are a few instances of "if(..)" -- our style
guidelines call for a space before the parenthesis.

+gdk-port:CONFIG  += link_pkgconfig

The += is indented weirdly here.

+gdk-port:CONFIG  += link_pkgconfig

Lining up the +='s with whitespace goes against our normal code style
guidelines, so it may not be a good idea in build scripts either.

The duplication of the INCLUDEPATH and gdk-port:* settings in WebCore.pro and
WebKit.pri isn't ideal. It'd be great if there were some way around it.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list