[Webkit-unassigned] [Bug 12959] REGRESSION: Edit -> Copy not enabled on standalone images

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12959


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13884|review?                     |review-
               Flag|                            |




------- Comment #4 from mitz at webkit.org  2007-03-30 04:40 PDT -------
(From update of attachment 13884)
Standalone image documents are mutable (via JS) after they're opened. This
means that this can deref a 0 pointer or set image to 0:

+        Node *image = doc->body()->firstChild();

It also means that renderer() here may be 0 or not a RenderImage:

+    RenderImage* renderer = static_cast<RenderImage*>(imageNode->renderer());

Please don't add another image:
+        * editing/pasteboard/resources/icon-gold.png: Added.

You can use editing/resources/abe.jpg.

\ No newline at end of file

Please add it.

Stars should be next to C++ types:
+        Document *doc = m_frame->document();
+        Node *image = doc->body()->firstChild();

+    void writeImage(Node *imageNode, const KURL& url);

+void Pasteboard::writeImage(Node *imageNode, const KURL& url)

But next to Obj-C object variables' names:
+    NSArray* types = writableTypesForImage();

r- because in its current form, the patch makes it possible for a website to
crash the browser.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.