[Webkit-unassigned] [Bug 12587] REGRESSION: VitalSource Bookshelf registering for a new account fails on Leopard9A214

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12587


adele at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from adele at apple.com  2007-03-28 14:18 PDT -------
3/27/07 6:11 PM Adele Peterson:
It would be really good to understand how this worked in Safari 2.0.  Let's
check out and debug on the 2.0 branch.

When you hit the "register" button, I see this in the bt:

#0  -[WebFrame loadRequest:] (self=0xec3b70, _cmd=0x90ab7174,
request=0x16d98080) at WebFrame.mm:729
#1  0x00049a14 in -[MiniRickController submitButtonClicked:] ()

The request is this:  <NSURLRequest
https://minirick.vitalbook.com/minirick/register.do?&mc=0016CB8A54E6&mn=adelembp&appName=VitalSource%20Bookshelf>

So...the request clearly doesn't have any form data in it.  And the normal form
submission process is not occurring.  Since we don't have the source of the
app, I think the next step is to debug a working version.

3/28/07 12:01 PM Adele Peterson:
[MiniRickController submitButtonClicked:] calls [WebView
stringByEvaluatingJavaScriptFromString:] with this script string: "return
document.forms[0].elements.length"

The JS execution has an error, and the app thinks that there are no form
elements, so it doesn't construct a good url to send to the registration page. 

Here is the error (from interpreter.cpp: 379): [13316]  line 1: SyntaxError:
Invalid return statement.

3/28/07 12:49 PM Adele Peterson:
After talking with Maciej, we realized that return values aren't allowed
outside of functions.  In Safari 2.0, we didn't check for this, and we allowed
it.  We should add a workaround for the app, and evangelize to get them to
change their code.  They could just submit the form itself (which is what
happens when you hit "Enter") instead of constructing a url with the form
values.

3/28/07 2:05 PM Adele Peterson:
Committed revision 20555.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.