[Webkit-unassigned] [Bug 13138] StringImpl::isLower calls |islower| for non-ASCII characters

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13138





------- Comment #13 from jungshik.shin at gmail.com  2007-03-24 20:52 PDT -------
(In reply to comment #5)

Thank you for your comments. I also stand corrected about ICU's islower. 

> The other is "is lowercase ASCII". There are lots of places that need this
> operation. I believe that if you look at the clients of StringImpl::isLower
> you'll see that "is all lowercase ASCII" is what almost all those clients want.
> So we might want to rename it. There's no reason to use the more-general much
> slower "is lowercase" operation.

I'm well aware that there are numerous cases in web browsers where we need fast
ASCII-only lowercasing and case-insensitive comparison/match. (BTW, it needs to
be noted that assuming all-ASCII on call-sites are *incorrect* in some cases.) 
That being said, I agree that we may as well have a separate API for an
ASCII-only string : isLowerASCII   


> Now as to the misuse of <ctype.h>, it's true, there's a lot of code that calls
> <ctype.h> and expects non-standard behavior of returning false for non-ASCII
> characters. We should fix all of that code. Not just StringImpl::isLower.

Yes. bug 12830 is one of them. 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.