[Webkit-unassigned] [Bug 13138] StringImpl::isLower calls |islower| for non-ASCII characters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 24 19:53:29 PDT 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #13799|review?(ap at webkit.org)      |review-
               Flag|                            |

------- Comment #7 from darin at apple.com  2007-03-24 19:53 PDT -------
(From update of attachment 13799)
This is not acceptable as-is. We need the high speed loop for all ASCII and the
loop can't have a branch in it or it won't be high speed. I suggest simply
and-ing with 0x7F before calling islower. We will ignore the result of islower
if the characters are not all ASCII.

    allLower &= islower(c & 0x7F);
    data[i] = tolower(c & 0x7F);

We use "FIXME:", not "XXX" for comments like that one about non-BMP.

+    // XXX Still broken for non-BMP characters represented in surrogate pairs

What non-BMP characters represented as surrogate pairs are lowercase? I don't
believe there are any. If there are, you should add a regression test to
demonstrate the symptom of the incorrect logic.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list