[Webkit-unassigned] [Bug 13138] StringImpl::isLower calls |islower| for non-ASCII characters

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13138





------- Comment #2 from jungshik.shin at gmail.com  2007-03-22 16:50 PDT -------
Different C libraries differ in the way they treat values beyond 0xFF. The man
page of islower on Mac OS 10.4 has the following to say about it. 



COMPATIBILITY
     The 4.4BSD extension of accepting arguments outside of the range of the
     unsigned char type in locales with large character sets is considered
     obsolete and may not be supported in future releases.  The iswlower()
     function should be used instead.

---------

Because the code in question is XP, I think we should not try to squeeze out
every bit of performance by being TOO clever, which may lead to a compatibility
issue.  

There are a couple of other places that use a similar trick in StringImpl.cpp.
I'll upload a patch soon. 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.