[Webkit-unassigned] [Bug 13029] Permit NPAPI plug-ins to see HTTP response headers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 20:46:33 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13029


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13710|review?                     |review+
               Flag|                            |




------- Comment #18 from darin at apple.com  2007-03-19 20:46 PDT -------
(From update of attachment 13710)
+        char statusStr[10];
+        sprintf(statusStr, "%d", [httpResponse statusCode]);

To avoid getting the security "cops" on our backs, lets use snprintf here
instead of plain old sprintf.

+    if (obj && (browser->version >= NPVERS_HAS_RESPONSE_HEADERS)) {
+        notifyStream(obj, stream->url, stream->headers);
+    }

No braces around a single-line if statement.

I'm going to say r=me, but I'd like to see a version with snprintf.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list