[Webkit-unassigned] [Bug 13029] Permit NPAPI plug-ins to see HTTP response headers

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13029


bdash at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13641|review?                     |review-
               Flag|                            |




------- Comment #16 from bdash at webkit.org  2007-03-19 02:38 PDT -------
(From update of attachment 13641)
Some of your new code in PluginObject.c uses if statements with the body on the
same line as the if.  This goes against our coding style guidelines
(<http://webkit.org/coding/coding-style.html>).  There are also a few instances
of single-line if statements having braces around their bodies.  We omit them
in this situation.

Rather than using cStringUsingEncoding: followed by appendBytes:length: it
would be cleaner to use dataUsingEncoding:.  This would also acommodate nul
bytes in the headers, though I suppose it's unlikely that this will happen. 
You also seem to nul-terminate theHeaders twice -- once when creating the
NSMutableData, and again when  converting it to a byte array.

Your test case looks good.  Some of the JavaScript doesn't match the style
guidelines (braces on same line as  function declaration, one-line if
statements with braces, etc.)

It'd be good to have another pass over this patch before it goes in.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.