[Webkit-unassigned] [Bug 11430] REGRESSION: Crash when loading PDF using AdobePDFViewer.plugin (Acrobat 7)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 18 09:34:29 PDT 2007


------- Comment #20 from ap at webkit.org  2007-03-18 09:34 PDT -------
Looks like the problem has been fixed during loader refactoring (which has
changed this code very heavily). I can not reproduce it anymore; here is what I

1) Hacked the return value of NPP_NewStream to be an error (matching how
Acrobat 7 worked), patch below.
2) Opened the bug URL - but Acrobat 8 doesn't even get to this point in code,
so it didn't prove anything.
3) Opened www.adobe.com/flash - the Flash plugin got this code to execute, but
WebKit didn't have any problem handling the error.

I couldn't test with Acrobat 7 because of bug 10510. However, I'm confused by
the duplicates that were filed much later than bug 10510, yet used Acrobat 7.
Does Acrobat 7 work for anyone with nightlies?

Index: /Users/ap/WebKit/WebKit/Plugins/WebBaseNetscapePluginStream.m
--- /Users/ap/WebKit/WebKit/Plugins/WebBaseNetscapePluginStream.m      
(revision 20268)
+++ /Users/ap/WebKit/WebKit/Plugins/WebBaseNetscapePluginStream.m      
(working copy)
@@ -234,6 +234,7 @@
     WebBaseNetscapePluginView *pv = pluginView;
     [pv willCallPlugInFunction];
     NPError npErr = NPP_NewStream(plugin, (char *)[MIMEType UTF8String],
&stream, NO, &transferMode);
+    npErr = 1;
     [pv didCallPlugInFunction];
     LOG(Plugins, "NPP_NewStream URL=%@ MIME=%@ error=%d", responseURL,
MIMEType, npErr);

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list