[Webkit-unassigned] [Bug 13072] REGRESSION (r15617): white-space: pre-wrap breaks off the last character of a wide word

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13072





------- Comment #2 from mitz at webkit.org  2007-03-14 13:58 PDT -------
This is the change in r15617:

     if (lBreak == start && !lBreak.obj->isBR()) {
         // we just add as much as possible
-        if (style()->whiteSpace() == PRE) {
+        if (style()->preserveNewline()) {
             // FIXME: Don't really understand this case.
             if (pos != 0) {

And this is the explanation from the change log:

+        * rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Took
a rule
+        that specifically called out the pre whitespace mode and made it work
for all
+        the modes that preserve newlines. This makes sure we get a last line
box for
+        text after the last "\n" even in cases where there is no <br>
afterward.

I'm not sure that rule was about preserving newlines. I don't understand it
either, but at least the (pos != 0) case seems wrong even for PRE.

Reverting the above change fixes the present bug and passes all layout tests.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.