[Webkit-unassigned] [Bug 13005] WebScriptObject +throwException needs NULL check

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13005


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13601|review?                     |review-
               Flag|                            |




------- Comment #8 from darin at apple.com  2007-03-12 21:18 PDT -------
(From update of attachment 13601)
Looks great. Only some minor problems:

++ (NSString *)webScriptNameForKey:(const char *)key {
++ (BOOL)isKeyExcludedFromWebScript:(const char *)key {
+- (void)dealloc {
+function print(message) {
+function test() {

We put the braces on the next line when defining functions, evein in
JavaScript.

The patch has a few tabs in it, and is missing blank lines in the change logs.
The change logs say "waylonis" for your name.

I can't tell how the test case detects success. For example, I could take the
throwOnDealloc behavior out of the test entirely, and the test would still seem
to succeed. Is there something we can do about that? Can we catch the
JavaScript exception?

I hate to review- when it's so close, but the tabs at least need to be fixed.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.