[Webkit-unassigned] [Bug 12973] REGRESSION: Reproducible assert while loading this test file if css is already in the cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 12:09:39 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12973





------- Comment #7 from ddkilzer at webkit.org  2007-03-10 12:09 PDT -------
(From update of attachment 13573)
Why is the m_sheet null check kept in one place, but not the other two?  In
both methods were the null check is not kept, m_sheet is used previously in the
method, but how do we know its value won't change between uses?

Not kept:

>Index: WebCore/dom/ProcessingInstruction.cpp
>-    // Tell the doc about the sheet.
>-    if (!isLoading() && m_sheet)
>-        document()->stylesheetLoaded();
>+    m_sheet->checkLoaded();
> }

Kept:

>Index: WebCore/dom/StyleElement.cpp
>-    if (!isLoading() && m_sheet)
>-        document->stylesheetLoaded();
>+    if (m_sheet)
>+        m_sheet->checkLoaded();
> }

Not kept:

>Index: WebCore/html/HTMLLinkElement.cpp
>-    // Tell the doc about the sheet.
>-    if (!isLoading() && m_sheet && !isDisabled() && !isAlternate())
>-        document()->stylesheetLoaded();
>+    m_sheet->checkLoaded();
> }


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list