[Webkit-unassigned] [Bug 12515] Plug-ins that draw through the Quickdraw interface fail in a CGBitmapContex.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12515


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13495|review?                     |review-
               Flag|                            |




------- Comment #19 from darin at apple.com  2007-03-07 06:42 PDT -------
(From update of attachment 13495)
This looks good and it is *almost* ready to go!

I looked at what effect this patch will have when the context is *not* a bitmap
context, because that's the part that could cause regressions.

And, I'm not trying to be nitpicky but ...

The patch moves the SetPort, PenNormal, ForeColor, BackColor, SetOrigin, and
SetPortClipRegion calls inside the "if (forUpdate)" if statement.

The ChangeLog doesn't say why that change is correct. Was it a mistake that
those functions were called in the "forUpdate is false" case before? If so, was
it simply inefficient to do the extra work, or was there actually a bug?

Another less important question. Is SetGWorld on the saved port from GetPort
really the best practice for restoring the old port? Or do we need to do a
GetGWorld rather than a GetPort to get the oldPort in the first place?

Otherwise looks great.

review- because the patch should contain the change to the ChangeLog (as Mark
said in his comment) but mainly because of the forUpdate change/issue above.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.