[Webkit-unassigned] [Bug 12963] Inconsistencies in JS array extras with Mozilla implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 00:47:52 PST 2007


jwalden+bwo at mit.edu changed:

           What    |Removed                     |Added
  Attachment #13470|0                           |1
        is obsolete|                            |

------- Comment #5 from jwalden+bwo at mit.edu  2007-03-05 00:47 PDT -------
Created an attachment (id=13476)
 --> (http://bugs.webkit.org/attachment.cgi?id=13476&action=view)
Full patch (but haven't attempted to run the tests yet)

(In reply to comment #4)
> It's hard to read this patch because it has so much context! I'm really used
> to the plain old "-u".

Not overdoing context is good, but since -p was useless I wanted enough to show
the names of the methods associated with each change.

> The code change looks fine, but we need some test cases and a change log
> before we can review+ this.

I whipped up some tests/changes earlier tonight as a break from classwork.  I'm
pretty sure the changes are correct, except possibly with respect to amounts of
(trailing) whitespace (ugh).  I should have access to a Mac tomorrow night, so
hopefully I'll be able to build/verify the tests then if no one else has (hence
no review flag yet).

By the way, these methods are all tested in Mozilla's JS test suite, which is
being reorganized to separate Moz-specific behaviors from ECMA-262 canon to aid
use by other implementations.  (There are nascent plans to try to make some
sort of generalized ECMA-262 test suite, but that's a while away for now.) 
Except for forEach returning undefined, I'd bet we have everything else tested
-- resyncing wouldn't be a bad idea if you have the time, as a further
correctness check.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list