[Webkit-unassigned] [Bug 12515] Plug-ins that draw through the Quickdraw interface fail in a CGBitmapContex.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 4 22:57:46 PST 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #13442|review?                     |review-
               Flag|                            |

------- Comment #13 from darin at apple.com  2007-03-04 22:57 PDT -------
(From update of attachment 13442)
+#import "WebKitSystemInterface.h"

Additional includes go down in the second block of includes, sorted
alphabetically. The topmost include is the one for the file's own header and
stands alone. Please put this down below in sorted order.

+                    // Get the clip bounds for the existing context to
minimize overdraw

When I said we wanted to respect the clip, I actually meant the entire set of
rectangles from NSView, not just the CGContext's clip.

+            // This prevents a potential crash if we don't obtain newWebView.

That's a nice additional fix, but we normally land our bug fixes separately,
with a test case for each one.

I'm going to say r=me, but I need to review- this because it doesn't have a
ChangeLog -- otherwise the person who commits this would have to write the
change log entry for you. Please post a new patch with a change log entry.

And ideally we'd come up with a way to test the lack of null check so someone
doesn't come and break it in the future. Since this involves both custom ObjC
code and a plug-in it might be challenging, but I think we have tests involving
both of those in our DumpRenderTree suite.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list