[Webkit-unassigned] [Bug 12885] REGRESSION (r19696): Incomplete background repaint

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12885


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13466|                            |review?
               Flag|                            |




------- Comment #6 from mitz at webkit.org  2007-03-03 13:20 PDT -------
(From update of attachment 13466)
(In reply to comment #4)
> 1) Figure out where to add the outline width. If it's left being done in
> absoluteBorderBox() is should probably be renamed.

Renamed to absoluteOutlineBox(). Also renamed getAbsoluteRepaintRect() to
absoluteClippedOverflowRect().

> 2) Consider having one function return both the absolute border box and the
> absolute repaint rect to avoid doing the recursion twice.

Didn't do it.

> 3) Fix the SVG renderers that currently pass IntRect() in.

Done.

> 4) Optimize repaintAfterLayoutIfNeeded(): it should not ask for the same area
> to be repainted twice (once as overflow and once as border box) and it should
> not ask to repaint border box area that was clipped out (all border box
> repaints should be clipped to the respective repaint bounds).

Done.

> 5) Check what happens with inset outlines (not really part of this bug, but I
> suspect they're not repainted correctly).

Need to file a separate bug on that. The present patch does not address it.

I also added a FIXME in RenderLayer::checkForRepaintOnResize(). I think it can
be eliminated, but I do not want to risk it now.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.