[Webkit-unassigned] [Bug 12939] New: npfunctions.h has declarations for NP_ entrypoints that don't match npupp.h

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12939

           Summary: npfunctions.h has declarations for NP_ entrypoints that
                    don't match npupp.h
           Product: WebKit
           Version: 412.x
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rsherry at adobe.com


In npupp.h, which is what has been used to build plug-ins for a while, the
declarations for the entrypoints for the exported functions have OSCALL in
front of them which translates to WINAPI on windows, which means Pascal.  All
netscape plug-ins current on windows (including Acrobat's) are compiled with
this.

In the WebKit, in WebKit/Plugins/npfunctions.h, there is no modifier to the
declaration for the entrypoint types, so the compiler thinks they're cdecl. 
This works on all platforms except windows, where the stack pointer gets messed
up.

We need to create a macro that resolves to WINAPI on Windows and nothing on
other platforms and put them into this declaration.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.