[Webkit-unassigned] [Bug 12931] ARM crash due to non-aligned memory access

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12931


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13433|review?                     |review-
               Flag|                            |




------- Comment #5 from darin at apple.com  2007-03-01 10:21 PDT -------
(From update of attachment 13433)
Looks fine.

+        const uint16_t* strChars = reinterpret_cast<const
uint16_t*>(str->characters());
+        const uint16_t* bufChars = reinterpret_cast<const uint16_t*>(buf.s);

These should just be const UChar* instead of const uint16_t*, and then you
won't need reinterpret_cast.

I think in the future we might want to reverse the if and enable the fast
32-bit-at-a-time path only on certain platforms. The ARM case can be the normal
case.

In fact, I don't think the ARM side needs a comment. Instead the comment should
be on the 32-bit side. Something like:

    // On platforms where it's safe to do so, it's faster to go 4 bytes at a
time.

review- because of the unneeded reinterpret_cast.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.