[Webkit-unassigned] [Bug 13664] REGRESSION: Extra letter in Webkit/Spell Catcher Shorthand (abbreviation) expansion

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13664





------- Comment #15 from evan at rainmakerinc.com  2007-06-30 14:31 PDT -------
(In reply to comment #14)
> It seems that Oliver's patch didn't fix this problem - I can still reproduce
> it.
> 

What/where's the patch?

I have figured out a way to get this working with Spell Catcher, but due to my
lack of knowledge about the various private parameters
(WebHTMLViewInterpretKeyEventsParameters ) being passed around (-insertText,
-doCommandBySelector), I have no idea whether it's going to break other input
methods.

In any case, it looks to me like the value of shouldSaveCommand is the key to
figure out whether the text/command is the result of an UpdateActiveInputArea
event. AND it looks like it's currently being used incorrectly. And checking
whether there's marked text or not to decide whether the event is from an input
method is just plain wrong. Input methods can send text via UAIA without
maintaining an active input area at all.

I'm hesitant to post a patch without knowing more about the reasoning behind
the changes that have been made since I last looked at this stuff. But if you
want me to post what I've got, I certainly can.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.