[Webkit-unassigned] [Bug 14455] Autogenerate the JS bindings for the StyleSheetList

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14455


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15307|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-06-30 11:37 PDT -------
(From update of attachment 15307)
+    HTMLStyleElement* element = thisObj->impl()->getNamedItem(propertyName);
+    return toJS(exec, element->sheet());

Looks like this won't do the right thing if element is 0. Maybe a pre-existing
problem?

-    // IE also supports retrieving a stylesheet by name, using the name/id of
the <style> tag
-    // (this is consistent with all the other collections)
-    // ### Bad implementation because returns a single element (are IDs always
unique?)
-    // and doesn't look for name attribute (see implementation above).
-    // But unicity of stylesheet ids is good practice anyway ;)

Where did all these comments go?

+HTMLStyleElement* StyleSheetList::getNamedItem(const String& name) const
+{
+    Element* element = m_doc->getElementById(name);

What guarantees the document in m_doc has not yet been destroyed?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.