[Webkit-unassigned] [Bug 13415] Add UTF-32 support for html/xml documents
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 29 02:13:01 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=13415
ap at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15303|review? |review-
Flag| |
------- Comment #14 from ap at webkit.org 2007-06-29 02:12 PDT -------
(From update of attachment 15303)
It seems that the change to html4.css does not belong to this patch.
+ setEncoding(((ptr - m_buffer.data()) % 4) ? "UTF-32LE" : "UTF-32BE",
AutoDetectedEncoding);
Since you've replaced encoding names with function calls in several places, I
suggest using those here, as well.
+ //else if (numBufferedBytes >= 3 || length >= 3)
We really do not like commented-out code in sources, please remove this line.
Coming to more important issues: I don't think I understand the algorithm in
TextDecoder::checkForBOM(). Why did you change m_bufferedBytes size to 4 bytes?
If we have already seen 4 bytes of the input, then we are done with BOM
detection, so only 3 bytes need be buffered. And the "encodingConsideringBOM !=
&m_encoding" check looks wrong, comparing TextEncoding by address is not a good
way to detect that we have successfully found a BOM.
This is extremely close to an r+, but I think that another iteration is needed
to iron out these issues.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list