[Webkit-unassigned] [Bug 14411] Regression: WebNetscapePluginPackage overagressively sets CurApRefNum, causes BBEdit to malfunction

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14411


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15246|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-06-26 13:43 PDT -------
(From update of attachment 15246)
Good change.

Tab in the ChangeLog will need ot be removed to check in. Also I'd like the
comment to mention the name and brief description of the bug, not just the ID.

Also, the (void) cast, while a common way to indicate that a function value is
ignored, is not something we generally do in WebKit/Core code. I'd prefer to
leave it out unless we have a tool that complains about ignored return values.
I think the emphasis on the fact that the function is being used for its side
effect is a good thing, but I think the comment already makes that clear and
the ugly syntax is only really worthwhile in code where it's consistently used.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.