[Webkit-unassigned] [Bug 14111] Autogenerate Event JS binding

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 12:32:51 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14111


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15250|review?                     |review+
               Flag|                            |




------- Comment #6 from ggaren at apple.com  2007-06-26 12:32 PDT -------
(From update of attachment 15250)
Looks good to me, unless other reviewers object.

+    if (!event)
+        return KJS::jsNull();
+
+    KJS::ScriptInterpreter* interp =
static_cast<KJS::ScriptInterpreter*>(exec->dynamicInterpreter());
+
+    KJS::JSLock lock;

The lock here needs to go at the top of the function. jsNull() used to perform
a GC allocation. There's no guarantee it won't again at some time in the
future.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list