[Webkit-unassigned] [Bug 14059] [CURL] Does not call didReceiveResponse()

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14059





------- Comment #5 from alp at atoker.com  2007-06-26 07:03 PDT -------
(In reply to comment #4)
> (From update of attachment 14924 [edit])
> Good improvement, but while you're at it, how about parsing the response
> headers too? Also, the curl docs imply that the callback you are changing gets
> called once per received header line, seems like that would be bad. According
> to libcurl docs:
> 
> "This function gets called by libcurl as soon as it has received header data.
> The header callback will be called once for each header and only complete
> header lines are passed on to the callback."

    if (strcmp("\r\n", ptr))
        return totalSize;

ie. the code that follows will only be run once, after the final header is
processed, so your concern is not valid but it's true the code could be less
obscurely written/commented.

Parsing the other response headers sounds like an interesting idea. I'll see
how it's meant to be done from the other http backends.

> 
> r- to revise in light of these comments.
> 

I'll get round to adding the comment and response header parsing in a few days,
but it's worth noting that the patch works as-is and unblocks a series of other
patches/bugs all the way up to making SVG support work.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.