[Webkit-unassigned] [Bug 14206] MSVC7 support and PLATFORM define fixes for Windows

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14206


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15094|review?                     |review-
               Flag|                            |




------- Comment #4 from mjs at apple.com  2007-06-26 00:38 PDT -------
(From update of attachment 15094)
Yes, please redo the conditionals like you said. Also, for the vsnprintf
changes, could you please make a wrapper of some kind (maybe just #define
vsnprintf _vsnprintf for the relevant compiler) instead of putting ifdefs at
every call site?

We prefer to avoid platform ifdefs in core code.

(Side not to Darin: on Windows the C library is distributed with the dev tools,
not with the OS, so I think the COMPILER checks are ok.)

Please revise.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.