[Webkit-unassigned] [Bug 13686] REGRESSION: Certain iframes embedded in page listed in History menu

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13686


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15051|review?                     |review-
               Flag|                            |




------- Comment #5 from mjs at apple.com  2007-06-25 20:11 PDT -------
(From update of attachment 15051)
Fix looks good to me. Please add a layout test. I believe this could be tested
using dumpBackForwardList().

The comment is subtly wrong:

+            // We only add the main frames to the history


We do, in fact, add loads of frames other than the main frame to the history,
if they are not initial loads, but that would not apply here.


------- Comment #6 from mjs at apple.com  2007-06-25 20:11 PDT -------
(From update of attachment 15051)
Fix looks good to me. Please add a layout test. I believe this could be tested
using dumpBackForwardList().

The comment is subtly wrong:

+            // We only add the main frames to the history


We do, in fact, add loads of frames other than the main frame to the history,
if they are not initial loads, but that would not apply here.


------- Comment #7 from mjs at apple.com  2007-06-25 20:11 PDT -------
(From update of attachment 15051)
Fix looks good to me. Please add a layout test. I believe this could be tested
using dumpBackForwardList().

The comment is subtly wrong:

+            // We only add the main frames to the history


We do, in fact, add loads of frames other than the main frame to the history,
if they are not initial loads, but that would not apply here.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.