[Webkit-unassigned] [Bug 13400] REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location

Mon Jun 25 20:06:20 PDT 2007

http://bugs.webkit.org/show_bug.cgi?id=13400

mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15072|review?                     |review-
               Flag|                            |

------- Comment #17 from mjs at apple.com  2007-06-25 20:06 PDT -------
(From update of attachment 15072)
Good catch, but I don't think this is quite the right fix. A location
assignment should add a new history item even if off a timer (at least if it's
not within a short time period of the original page load. See
modified-testcase.html.

In Firefox, it appears that assigning document.location in the normal way
*always* creates a new history item. See even-immediate-assignment.html. Given
this, I think the right thing is probably to always pass true as the
userGesture argument, but you may want to test other similar cases and add them
as LayoutTests if you think of other corner cases.

Otherwise this patch looks great!

-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.