[Webkit-unassigned] [Bug 14389] [S60] Widget Menu API needs refinement

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14389


zbujtas at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15232|review?(zbujtas at gmail.com)  |review-
               Flag|                            |




------- Comment #3 from zbujtas at gmail.com  2007-06-25 13:07 PDT -------
(From update of attachment 15232)
widgetExtension.cpp line#860
>if ( newItem && oldItem && newItem->Text().Compare(newItem->Text()) != 0 )
shouldn't it be something like if ( newItem && oldItem &&
newItem->Text().CompareF(oldItem->Text()) == 0 ) ?

WidgetPreferences.cpp 
- remove tabs, please.
- line# 225, 251: missing CleanupStakc: PushL
- line# 436: use allocL() instead
- linr# 444: iValue = null; is missing and use allocL() instead.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.