[Webkit-unassigned] [Bug 13884] patch for prepare-ChangeLog to populate ChangeLog files from a git commit

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13884


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15186|review?                     |review+
               Flag|                            |




------- Comment #21 from aroben at apple.com  2007-06-22 12:45 PDT -------
(From update of attachment 15186)
+            $command = "$GIT diff -r --name-status -M \"$gitCommit^\"
\"$gitCommit\"";

   We should probably pass -C here as well.

     return $git{$status} if isGit();
+    return 0 if $gitCommit; # an existing commit cannot have conflicts

   Shouldn't these two lines be reversed?

+    # deliberately share the same description between svn status output and
git diff --name-status
+    return sprintf($svn{$status}, $original) if (isSVN() || $gitCommit) &&
exists $svn{$status};

   I guess we now know that the description for "R" is different for the
$gitCommit case.

   These are all pretty minor, so r=me either way, though I'd like to see them
addressed at some point.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.