[Webkit-unassigned] [Bug 13884] patch for prepare-ChangeLog to populate ChangeLog files from a git commit

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13884





------- Comment #17 from aroben at apple.com  2007-06-22 12:03 PDT -------
(In reply to comment #16)
> AFAIK svn uses R for replaced, which git doesn't use.

   Actually, git confusingly uses R to mean "renamed" rather than "replaced".
This is probably a bug that should be fixed in git, since --name-status is
striving to be svn-compatible. But it does seem that "R" should be in this map.

> The reason why I've added
> "D" is to handle the case when a commit consists only of file deletions. That
> is of course strictly speaking not a modified or added state, but if it's not
> handled here then prepare-ChangeLog thinks nothing changed at all, which isn't
> correct either. I've just tried with a svn checkout and the same happens there,
> too (svn rm WebCore/Makefile; WebKitTools/Scripts/prepare-ChangeLog -> No
> changes found).

   Ah, that's a problem I've noticed before as well. However, I think just
adding "D" to this map will cause the undesired effect of showing _every_
deleted file beneath a deleted directory, so we need to be a bit smarter about
this case. I think for now I'd prefer leaving just %svnStatus as is and using
it for the git-commit case. Then we can file and fix the "doesn't show deleted
files" bug separately.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.