[Webkit-unassigned] [Bug 14206] MSVC7 support and PLATFORM define fixes for Windows

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14206





------- Comment #2 from darin at apple.com  2007-06-21 23:55 PDT -------
(From update of attachment 15094)
A lot of these things look like library differences rather than compiler
differences. Should we really be using a COMPILER check for them?

+#if _MSC_VER >= 1400
+#define WTF_COMPILER_MSVC8 1
+#else
+/* assumes everything else is like MSVC7 */
+#define WTF_COMPILER_MSVC7 1
+#endif

I'd prefer the logic be reversed. The past should be the exceptional case, and
the future should be the normal case. But anyway, I don't think the new thing
should be called MSVC8 -- we don't want any MSVC8 conditionals in the code
until we know how it differs from MSVC9, for example.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.