[Webkit-unassigned] [Bug 13884] patch for prepare-ChangeLog to populate ChangeLog files from a git commit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 16:25:27 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13884





------- Comment #12 from aroben at apple.com  2007-06-21 16:25 PDT -------
(From update of attachment 14848)
+            return "$GIT diff \"$gitCommit\" \"$gitCommit^\"";

The order of these arguments seems reversed to me -- won't this give you a
reversed diff?

+            $command = "$GIT diff -r --name-status -M \"$gitCommit\"
\"$gitCommit^\"";

Ditto.

+                } elsif (/^(R)[0-9]{1,3}\t([^\t]+)\t([^\t\n]+)$/) {

It would be nice to have an example of a line this would match (I know I didn't
do this for some other gnarly regexps in this script, but we need to start
somewhere)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list