[Webkit-unassigned] [Bug 14147] REGRESSION: No history item created when viewing "All Sizes" on Flickr

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14147


mbritto at pleyo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15137|                            |review?
               Flag|                            |




------- Comment #2 from mbritto at pleyo.com  2007-06-20 05:17 PDT -------
Created an attachment (id=15137)
 --> (http://bugs.webkit.org/attachment.cgi?id=15137&action=view)
proposed patch

The call for scheduleLocationChange() in JSHTMLDocument::setLocation() 
(JSHTMLDocumentCustom.cpp) was missing an argument (userGesture) and the
default behavior in scheduleLocationChange() was to consider it false.
As this JS event was not considered as userGesture initiated, his load type was
internal and it wasn't added to the history.
With this modification I can no longer reproduce the bug


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.