[Webkit-unassigned] [Bug 13884] patch for prepare-ChangeLog to populate ChangeLog files from a git commit

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13884


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14848|review?                     |review-
               Flag|                            |




------- Comment #10 from timothy at hatcher.name  2007-06-15 07:14 PDT -------
(From update of attachment 14848)
These two changes seem wrong. Why are you changing the line that has isSVN()
and testing for $gitCommit there? Shouldn't that be on the line with isGit()?

@@ -999,7 +1074,7 @@ sub isModifiedOrAddedStatus($)
         "renamed" => 1,
     );

-    return $svn{$status} if isSVN();
+    return $svn{$status} if (isSVN() || $gitCommit);
     return $git{$status} if isGit();
 }

@@ -1037,7 +1112,7 @@ sub statusDescription($$)
         "renamed" => " Renamed from \%s.",
     );

-    return sprintf($svn{$status}, $original) if isSVN() && exists
$svn{$status};
+    return sprintf($svn{$status}, $original) if (isSVN() || $gitCommit) &&
exists $svn{$status};
     return sprintf($git{$status}, $original) if isGit() && exists
$git{$status};
     return undef;
 }


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.