[Webkit-unassigned] [Bug 14142] New: SVG text gradients are busted on feature-branch

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14142

           Summary: SVG text gradients are busted on feature-branch
           Product: WebKit
           Version: 522+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


SVG text gradients are busted on feature-branch

This happened due to my adding painting outline support.  The one-line fix is
thus:

Index: rendering/SVGRootInlineBox.cpp
===================================================================
--- rendering/SVGRootInlineBox.cpp      (revision 23529)
+++ rendering/SVGRootInlineBox.cpp      (working copy)
@@ -112,7 +113,7 @@

 void SVGRootInlineBox::paint(RenderObject::PaintInfo& paintInfo, int tx, int
ty)
 {
-    if (paintInfo.context->paintingDisabled())
+    if (paintInfo.context->paintingDisabled() || paintInfo.phase !=
PaintPhaseForeground)
         return;

     FloatRect boundingBox;

I don't think the root inline box needs to ever paint in any other phase.

I also did a small amount of clenaup in this patch.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.