[Webkit-unassigned] [Bug 12207] RenderSVGContainer should be split into multiple classes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12207


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14988|review?                     |review+
               Flag|                            |




------- Comment #11 from eric at webkit.org  2007-06-13 16:09 PDT -------
(From update of attachment 14988)
Eventually we'll need a better solution to this:

+        // FIXME: All this setup should be done after attributesChanged, not
here.
+        rootContainer->setViewBox(viewBox());
+       
rootContainer->setAlign(SVGPreserveAspectRatio::SVGPreserveAspectRatioType(preserveAspectRatio()->align()));
+        rootContainer->setSlice(preserveAspectRatio()->meetOrSlice() ==
SVGPreserveAspectRatio::SVG_MEETORSLICE_SLICE);

We'll need to find a way to abstract a bunch of this code so it's not so
copy/paste.

It looks fine for a start.  We'll need follow up patches to clean up these
newly split classes.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.