[Webkit-unassigned] [Bug 14126] New: Shell scripts to build WebKit should be forced to LF endings

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14126

           Summary: Shell scripts to build WebKit should be forced to LF
                    endings
           Product: WebKit
           Version: 522+ (nightly)
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zerodpx at gmail.com


Checking out WebKit on Windows can lead to problems with line endings that
cause the build to break, because the shell scripts used in the build process
are checkout out with native line endings rather than LF.  aroben noted (on
IRC) that while people who use the SVN provided with Cygwin should not suffer
from this problem, the line endings should probably be fixed anyway.

Fixing this is as simple as the following:
$ svn propset svn:eol-style LF <files>
...Wherer <files> is the following set:
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh
JavaScriptCore/make-generated-sources.sh
WebCore/css/makeprop
WebCore/css/maketokenizer
WebCore/css/makevalues
WebCore/make-generated-sources.sh
WebCore/move-js-headers.sh
WebCore/WebCore.vcproj/build-generated-files.sh
WebKit/win/WebKit.vcproj/auto-version.sh
WebKitTools/CygwinDownloader/make-zip.sh

(The files in WebCore/css/ have no shell specifier at the top of the file, but
need to be modified as well, as far as I can tell.  I don't know if there are
even more files in the build process that need this tweak; I haven't gotten my
build to complete successfully yet.)

I tried to write a patch to do this, but got errors from svn-create-patch :(. 
So someone with commit access will have to handle this one.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.