[Webkit-unassigned] [Bug 14059] [CURL] Does not call didReceiveResponse()

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14059





------- Comment #2 from freyther at handhelds.org  2007-06-13 08:05 PDT -------
+  if (strcmp("\r\n", ptr))
+        return totalSize;

A comment describing why this guard is the right one would be awesome. We wen
through this on irc and I agree that it is sufficient.




+    KURL url(hdr);
+    if (hdr) {

a) could you move KURL url handling further down? It is only used at the last
line of this method and it would increase readability
b) Is it documented how KURL(const char*) is handling possible NULL strings? Or
is it only possible that the second call where hdr is used returns a NULL
string?
c) Would it be too much work to not reuse the char* hdr but have a variable
name describing this thing better?


+        char* buf = strdup(hdr);
I think we don't care for the case where this fails?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.