[Webkit-unassigned] [Bug 13976] getPresentationAttribute not implemented

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13976





------- Comment #4 from eric at webkit.org  2007-06-04 11:19 PDT -------
(From update of attachment 14846)
This check seems unnecessary:
+    if (SVGStyledElement::cssPropertyIdForSVGAttributeName(cssSVGAttr->name())
<= 0)
+        return 0;

It's very possible that SVG elements could be carrying style from non-SVG
attributes.  I don't see why we would want to intentionally disable access to
these properties via this call.

Using CDATA blocks is probably easier to read than &amp; ;)

The test would also be clearer if it was 3 checks instead of one check for 3
things.

You also don't test mutability as the spec requires.

I think the code looks OK, but the test should be improved before landing.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.