[Webkit-unassigned] [Bug 13985] WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13985


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14851|                            |review-
               Flag|                            |




------- Comment #2 from ddkilzer at webkit.org  2007-06-04 09:48 PDT -------
(From update of attachment 14851)
Thanks for posting a patch to fix this, Bernhard!

In the future, please set the "review?" flag on patches so that they may be
flagged for review, and please add a ChangeLog entry for the updates.  See this
page for more details:  http://webkit.org/coding/contributing.html

>-                borderWidth = max(borderWidth, gb.width);
>+                borderWidth = max(borderWidth, (unsigned int)gb.width);

In all of these cases, we prefer to use the static_cast<>() syntax and
"unsigned" instead of "unsigned int":

>+                borderWidth = max(borderWidth, static_cast<unsigned>(gb.width));

Please add a ChangeLog entry, update the patch and repost.  Thanks!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.