[Webkit-unassigned] [Bug 12430] SVG has two transform parsers when it should have one.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12430





------- Comment #2 from eric at webkit.org  2007-06-02 11:05 PDT -------
(From update of attachment 14840)
The assignment here doesn't ned to be on separate lines:

+        SVGTransformable::parseTransformValue(m_type, ptr, ptr +
m_from.length(), t);
+        m_fromTransform = t;

You could just pass m_fromTransform (if you're not gonna check the bool return
anyway)

Personally I might give required/optional longer names.  Like
requireParamsForTransformType or even requiredForType or something.

Neither of those are functional issues.  I'm perhaps still too asleep give this
a careful review.   More later.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.