[Webkit-unassigned] [Bug 14757] REGRESSION: HTMLTokenizer::processingData implementation is incorrect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 12:43:53 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14757


beidson at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15709|review?                     |review-
               Flag|                            |




------- Comment #18 from beidson at apple.com  2007-07-31 12:43 PDT -------
(From update of attachment 15709)
I think this fix is pretty darned good.  
r- for one issue.
You replace the stopForUserCancel() call with a stopAllLoaders() and
scheduleCheckLoadComplete() call.
It is not obvious to me that those two lines replace the behavior of
"stopForUserCancell()" but just do it asynchronously.
I think it'd be better for future maintainability if stopForUserCancel() had an
asynchronous flag added, and that method decides whether to do the load
complete check now, or later.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list