[Webkit-unassigned] [Bug 14729] [gtk] Implement FrameLoaderClientGdk::createFrame

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14729


freyther at handhelds.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15756|                            |review?
               Flag|                            |




------- Comment #7 from freyther at handhelds.org  2007-07-31 07:19 PDT -------
Created an attachment (id=15756)
 --> (http://bugs.webkit.org/attachment.cgi?id=15756&action=view)
Implement ScrollView similiar to win/qt

Compared to the previous patch:

-Make it compile on case-sensitive filesystems (PlatformScrollbar.h vs.
PlatformScrollBar.h)
-Add (again) refcounting to PlatformScrollbar and ScrollView
-Implement forall and unrealize in WebKitGtkPage to make issues on exit go
away.
-Fixup some comments.

The biggest part of the patch is copy and paste from the windows port. The
controversal change is in Widget to use one of the two possible IntRect
conversion methods. I think this change is fine, other approaches would be to
move this code to PlatformScrollbar or to subclass PlatformScrollbar and use
that subclss in ScrollView.

I think this is commit-worthy.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.